add mypy check#42
Merged
chrishavlin merged 1 commit intodata-exp-lab:mainfrom Apr 1, 2025
Merged
Conversation
chrishavlin
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 97.43% 98.28% +0.85%
==========================================
Files 11 11
Lines 585 643 +58
==========================================
+ Hits 570 632 +62
+ Misses 15 11 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chrishavlin
force-pushed
the
enable_typechecking_ci
branch
from
0bcb85e to
918973b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in progress: still some failures (22 locally)This adds a mypy check to CI and fixes a bunch of type hints. Pretty minimal changes to the code were necessary: just a bit of refactoring to make the typing simpler.